Merge lp://staging/~gary/juju-quickstart/authtoken into lp://staging/juju-quickstart

Proposed by Gary Poster
Status: Merged
Merged at revision: 23
Proposed branch: lp://staging/~gary/juju-quickstart/authtoken
Merge into: lp://staging/juju-quickstart
Diff against target: 272 lines (+110/-28)
6 files modified
quickstart/app.py (+17/-2)
quickstart/juju.py (+17/-0)
quickstart/manage.py (+6/-3)
quickstart/tests/test_app.py (+46/-18)
quickstart/tests/test_juju.py (+6/-0)
quickstart/tests/test_manage.py (+18/-5)
To merge this branch: bzr merge lp://staging/~gary/juju-quickstart/authtoken
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+196982@code.staging.launchpad.net

Description of the change

Add autologin support for quickstart

To qa, please do the following.

Story 1: quickstart works without autologin support for charm.

Simply run `.venv/bin/python juju-quickstart`. This will bring up the existing charm, which does not have support for autologin. It should work fine, with password.

Story 2: quickstart works with autologin when available.

Run `.venv/bin/python juju-quickstart --gui-charm-url cs:~juju-gui/precise/juju-gui-134`.

This should bring up the GUI with autologin.

Thank you!

https://codereview.appspot.com/34420043/

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+196982_code.launchpad.net,

Message:
Please take a look.

Description:
Add autologin support for quickstart

To qa, please do the following.

Story 1: quickstart works without autologin support for charm.

Simply run `.venv/bin/python juju-quickstart`. This will bring up the
existing charm, which does not have support for autologin. It should
work fine, with password.

Story 2: quickstart works with autologin when available.

Run `.venv/bin/python juju-quickstart --gui-charm-url
cs:~juju-gui/precise/juju-gui-134`.

This should bring up the GUI with autologin.

Thank you!

https://code.launchpad.net/~gary/juju-quickstart/authtoken/+merge/196982

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/34420043/

Affected files (+112, -28 lines):
   A [revision details]
   M quickstart/app.py
   M quickstart/juju.py
   M quickstart/manage.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_juju.py
   M quickstart/tests/test_manage.py

Revision history for this message
Madison Scott-Clary (makyo) wrote :
Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Add autologin support for quickstart

To qa, please do the following.

Story 1: quickstart works without autologin support for charm.

Simply run `.venv/bin/python juju-quickstart`. This will bring up the
existing charm, which does not have support for autologin. It should
work fine, with password.

Story 2: quickstart works with autologin when available.

Run `.venv/bin/python juju-quickstart --gui-charm-url
cs:~juju-gui/precise/juju-gui-134`.

This should bring up the GUI with autologin.

Thank you!

R=matthew.scott
CC=
https://codereview.appspot.com/34420043

https://codereview.appspot.com/34420043/

Revision history for this message
Gary Poster (gary) wrote :

Thank you for the review and QA, Matt.

https://codereview.appspot.com/34420043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: