Merge lp://staging/~gary/juju-quickstart/authtoken into lp://staging/juju-quickstart
Proposed by
Gary Poster
Status: | Merged |
---|---|
Merged at revision: | 23 |
Proposed branch: | lp://staging/~gary/juju-quickstart/authtoken |
Merge into: | lp://staging/juju-quickstart |
Diff against target: |
272 lines (+110/-28) 6 files modified
quickstart/app.py (+17/-2) quickstart/juju.py (+17/-0) quickstart/manage.py (+6/-3) quickstart/tests/test_app.py (+46/-18) quickstart/tests/test_juju.py (+6/-0) quickstart/tests/test_manage.py (+18/-5) |
To merge this branch: | bzr merge lp://staging/~gary/juju-quickstart/authtoken |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+196982@code.staging.launchpad.net |
Description of the change
Add autologin support for quickstart
To qa, please do the following.
Story 1: quickstart works without autologin support for charm.
Simply run `.venv/bin/python juju-quickstart`. This will bring up the existing charm, which does not have support for autologin. It should work fine, with password.
Story 2: quickstart works with autologin when available.
Run `.venv/bin/python juju-quickstart --gui-charm-url cs:~juju-
This should bring up the GUI with autologin.
Thank you!
To post a comment you must log in.
Reviewers: mp+196982_ code.launchpad. net,
Message:
Please take a look.
Description:
Add autologin support for quickstart
To qa, please do the following.
Story 1: quickstart works without autologin support for charm.
Simply run `.venv/bin/python juju-quickstart`. This will bring up the
existing charm, which does not have support for autologin. It should
work fine, with password.
Story 2: quickstart works with autologin when available.
Run `.venv/bin/python juju-quickstart --gui-charm-url gui/precise/ juju-gui- 134`.
cs:~juju-
This should bring up the GUI with autologin.
Thank you!
https:/ /code.launchpad .net/~gary/ juju-quickstart /authtoken/ +merge/ 196982
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/34420043/
Affected files (+112, -28 lines): manage. py tests/test_ app.py tests/test_ juju.py tests/test_ manage. py
A [revision details]
M quickstart/app.py
M quickstart/juju.py
M quickstart/
M quickstart/
M quickstart/
M quickstart/