Code review comment for lp://staging/~gary/juju-gui/setconfigfix

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Fix sandbox setconfig and associated test

The sandbox setconfig test was taking over a second--a pretty clear
indication that it was waiting on the fake delta stream rather than a
direct response. Investigation revealed that the sandbox method was
incorrectly using the ASYNCOP helper rather than the OP helper. This
small branch fixes the setconfig problem and adjusts the tests. The
test is very fast now (not yellow or red in the mocha output).

R=bac, matthew.scott
CC=
https://codereview.appspot.com/8663043

https://codereview.appspot.com/8663043/

« Back to merge proposal