lp://staging/~gary/juju-gui/setconfigfix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 537

Juju GUI Hackers: Pending requested 2013-04-11

Diff: 30 lines (+4/-2)

2 files modified

app/store/env/sandbox.js (+1/-1)
test/test_sandbox.js (+3/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

536. By Gary Poster on 2013-04-11

fix lint

535. By Gary Poster on 2013-04-11

fix sandbox setconfig implementation to return result. after adjusting test, this eliminates one second from the test suite.

534. By Gary Poster on 2013-04-11

Fix bug 1166222

The Go environment is unwilling to load a charm before it is part of the environment, which broke our new endpoints implementation. Luckily, fixing it ended up being a nice cleanup on our side, I think. We do not need the charm until it is no longer a ghost.

R=teknico, frankban
CC=
https://codereview.appspot.com/8647043

533. By Gary Poster on 2013-04-10

Make safe relation ids in environment view

Relation ids included spaces and other problematic chacracters in our related DOM ids. This branch cleans those up, and also does a quick CSS cleanup to make some text legible again.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/8640043

532. By Richard Harding on 2013-04-10

Add UX styling to the sidebar and container UI

- Theme the containers
- Adjust the container to be clickable/toggleable thruogh the whole heading.
- Add the active state to the charms in the sidebar
- Adjust some of the CSS for the charm details to present in the sidebar view.

R=jeff.pihach
CC=
https://codereview.appspot.com/8618044

531. By j.c.sackett on 2013-04-10

Removes remaining references to charm slider

While the slider is gone, there were elements that still expected slider data;
sliderCharms, sliderContainers, and the slider class in the template.

All of these things are replaced by "featured" (e.g. featuredCharms), which is
the new container category replacing the slider in the design.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8600043

530. By Richard Harding on 2013-04-10

Update the charm details to show changelog detail

- Update the model to pull/parse the commit data from the source_code data
- add some model tests around the parsing of the commit data and a couple of
other model attrs
- Update the view to handle getting the commit data into stuff that's
handlebars friendly
- update to display/show/hide changelog details.

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/8621043

529. By Jeff Pihach on 2013-04-10

Implemented add-relation for the fakebackend

In order to implement add-relation for the fakebackend
a large change was needed in the fake charmstore in
tests/utils.js in order to allow us to load in real
charm data.

Add-relation also appears to be the only command which
has it's input data altered in the python.js endpoint
so it needs to support two different types of input
while maintaining as close to identical responses.

R=bcsaller, gary.poster
CC=
https://codereview.appspot.com/8578043

528. By Nicola Larosa on 2013-04-10

Add destroy_service to the Go environment.

Add destroy_service to the Go environment, with tests.

Remove handleSetConfig from the Go environment: it is the same
as handleServiceCalls, used in its place.

Add tests for destroy_service to the Python environment too.

Increase the timeout in the test's index.html, to make debug tests
pass on my slow machine.

R=frankban, bac
CC=
https://codereview.appspot.com/8618043

527. By Brad Crittenden on 2013-04-10

Change Go get_service results to match others.

Also bolster tests.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8623043