LGTM with a small comment request. QA OK Thanks for this fix!
https://codereview.appspot.com/22500043/diff/1/app/views/viewlets/inspector-header.js File app/views/viewlets/inspector-header.js (right):
https://codereview.appspot.com/22500043/diff/1/app/views/viewlets/inspector-header.js#newcode59 app/views/viewlets/inspector-header.js:59: var name = pojoModel.displayName.match(/^\(([^)]*)\)$/)[1]; I'd love it if there was a quick comment describing what this regex looks for to make the code easier to scan.
https://codereview.appspot.com/22500043/diff/1/test/test_ghost_inspector.js File test/test_ghost_inspector.js (right):
https://codereview.appspot.com/22500043/diff/1/test/test_ghost_inspector.js#newcode50 test/test_ghost_inspector.js:50: env.connect(); Ahh the shibboleth of writing environment tests.....you may proceed.
https://codereview.appspot.com/22500043/
« Back to merge proposal
LGTM with a small comment request.
QA OK
Thanks for this fix!
https:/ /codereview. appspot. com/22500043/ diff/1/ app/views/ viewlets/ inspector- header. js viewlets/ inspector- header. js (right):
File app/views/
https:/ /codereview. appspot. com/22500043/ diff/1/ app/views/ viewlets/ inspector- header. js#newcode59 viewlets/ inspector- header. js:59: var name = displayName. match(/ ^\(([^) ]*)\)$/ )[1];
app/views/
pojoModel.
I'd love it if there was a quick comment describing what this regex
looks for to make the code easier to scan.
https:/ /codereview. appspot. com/22500043/ diff/1/ test/test_ ghost_inspector .js ghost_inspector .js (right):
File test/test_
https:/ /codereview. appspot. com/22500043/ diff/1/ test/test_ ghost_inspector .js#newcode50 ghost_inspector .js:50: env.connect();
test/test_
Ahh the shibboleth of writing environment tests.....you may proceed.
https:/ /codereview. appspot. com/22500043/