lp://staging/~gary/juju-gui/nameCheck

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1186

Juju GUI Hackers: Pending requested 2013-11-06

Diff: 135 lines (+70/-16)

3 files modified

app/views/ghost-inspector.js (+10/-0)
app/views/viewlets/inspector-header.js (+13/-16)
test/test_ghost_inspector.js (+47/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1185. By Gary Poster on 2013-11-06

add explanatory comments per review

1184. By Gary Poster on 2013-11-06

merge trunk

1183. By Gary Poster on 2013-11-06

fix name validation

1182. By Gary Poster on 2013-11-06

Improve browser description formatting

I saw antdillon's branch to improve the formatting and really liked the idea (https://code.launchpad.net/~ya-bo-ng/juju-gui/linkify-charm-descriptions/+merge/192852). However, I wanted to improve the testing and the XSS behavior. Trying to accomplish the second of those involved quite a bit of changes from his original design, but there's still a regex in there or two.

To QA, look at the mediawiki summary tab. Note that the change log and description now are better formmatted, and have links, and break only for long stuff. mongodb's description shows the pre-line formatting off, and liferay's description shows why truncating at 300 characters was problematic--a url might be cut in half. I thought of some approaches to try and make that work, but I thought that removing the 300 character limit looked better anyway. cassandra's change log is another one to look at: the pre-line works well, I think, and there are a few links to look at in the "earlier changes" section when you expand the change log.

R=huwshimi, rharding
CC=
https://codereview.appspot.com/22200045

1181. By Gary Poster on 2013-11-05

Use the new deployer url in our help text

To QA, use the charmworldv3 flag and open up a bundle (search for hatch, for instance) and go to the deploy flag. The instructions there should be helpful and good.

R=rharding
CC=
https://codereview.appspot.com/21980043

1180. By Gary Poster on 2013-11-05

Remove charmworldv3 and APIv2

For QA, make sure that you can search for bundles (e.g., search for hatch) and make sure that the charm store seems to be working correctly.

R=rharding, bac
CC=
https://codereview.appspot.com/22000043

1179. By Gary Poster on 2013-11-05

Re-enable Landscape sim and fix inspector link

Changes to move units to service attributes broke the Landscape simulation because they were buggy, and we had no tests. Fixing that revealed that Landscape links were broken in the inspector if units appeared with Landscape problems while you observed the inspector. This branch also fixes that problem.

To QA, run the simulator on the sandbox and create 100 or 200 units in a service. Keep the inspector open after creation. You should see a few Landscape issues appear within a few seconds. If you open up the Landscape sections of the inspector, the link to Landscape at the bottom of the section should have a href that looks vaguely like it might point to Landscape, if Landscape were really hooked up.

R=rharding
CC=
https://codereview.appspot.com/21440044

1178. By Richard Harding on 2013-11-04

Remove "deploy from quicksearch" feature flag.

R=
CC=
https://codereview.appspot.com/21480044

1177. By Jeff Pihach on 2013-11-02

Fixes bundle vis for charms without versions

Some of Jorge's bundles didn't have versions specified
so they would not show up in the bundle visualizations
or allow them to be deployed. This fixes that limitation
and improves the error reporting when the user tries to
deploy two bundles with services that have the same names.

R=gary.poster
CC=
https://codereview.appspot.com/21020043

1176. By Madison Scott-Clary on 2013-11-01

Autoposition services w/o annotations in bundles

If a bundle does not have service position annotations, generate a default layout and provide a textual warning for the user. As a drive-by, the centering code was fixed to properly center the topology.

To QA, check that the following URLs render decent-looking bundles:
* /sidebar/search/bundle/~makyo/openstack/2/openstack/:flags:/charmworldv3/?text=makyo
* /sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=benji#bws-bundle
* /sidebar/search/bundle/~hatch/wiki/6/envExport/:flags:/charmworldv3/?text=hatch
* /sidebar/search/bundle/~hatch/wiki/7/TestBundle/:flags:/charmworldv3/?text=hatch

R=jeff.pihach
CC=
https://codereview.appspot.com/20870043