Code review comment for lp://staging/~gary/juju-gui/fixGoSandboxWatcher2

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Fix Go sandbox AllWatcher initialization

The Go sandbox AllWatcher was trying to send deltas immediately, which
does not match the juju core implementation. This fixes the behavior,
with a test.

It also fixes a user-visible bug. To qa, turn off the simulator in the
config file, and then deploy a service in the default go sandbox.
Before my branch, the unit would never appear, because the delta for
this change was lost. After my branch, the unit appears correctly.

R=matthew.scott
CC=
https://codereview.appspot.com/14548050

https://codereview.appspot.com/14548050/

« Back to merge proposal