lp://staging/~gary/juju-gui/fixGoSandboxWatcher2

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1129

Juju GUI Hackers: Pending requested 2013-10-11

Diff: 34 lines (+6/-5)

2 files modified

app/store/env/sandbox.js (+4/-4)
test/test_sandbox_go.js (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1129. By Gary Poster on 2013-10-11

fix go sandbox all watcher initialization

1128. By Francesco Banconi on 2013-10-11

Update the release process documentation.

Added the charm release steps.

R=rharding
CC=
https://codereview.appspot.com/14531051

1127. By Jeff Pihach on 2013-10-11

Deletes the databindings when they are detached

Because the left panel slot on the inspector gets destroyed
when switching between the unit/charm details views the databinding
would attempt to rebind to elements which didn't exist any longer.

This branch handles removing the databindings from the master list
of bindings when they are detached.

R=benjamin.saller
CC=
https://codereview.appspot.com/14489044

1126. By Benjamin Saller on 2013-10-10

Fix annotations on go backend

Fix annotation roundtrips with go backend
      Splits how we prepare deltas for py/go juju fakebackends
      Change test expectations to merge updateAnnotation calls

  Fix import of constraints
  Fix export of undefined/default values

  Adjust simulator unit count rate of change.

R=benjamin.saller, gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/14485046

1125. By Francesco Banconi on 2013-10-10

Fix links in the unit details view.

Handle the juju-core "port/protocol" ports.
Privilege the HTTPS port if applicable.

Also fixed the z-index of the charm browser tab,
so that when the sidebar and the unit details view
appear together in a narrow browser it is still
possible to close the sidebar.

QA:
- deploy the GUI with this branch in a juju-core env:
  juju bootstrap --debug
  juju deploy juju-gui
  juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/inspector-who
- wait for the unit to be ready;
- visit the juju-gui unit detail view;

You should be able to close the sidebar view.
The GUI address links to the right URL (https://).
The ports link to the right URLs without the trailing "/tcp".

R=jeff.pihach
CC=
https://codereview.appspot.com/14439054

1124. By Huw Wilkins on 2013-10-10

Added bundle details panel icon and visibility

On the bundle details overview I added the charm icon to the charm details panel. I also added showing and hiding of that panel.

R=gary.poster
CC=
https://codereview.appspot.com/14515049

1123. By Jeff Pihach on 2013-10-10

Added the source code tab to bundle details view

R=gary.poster
CC=
https://codereview.appspot.com/14595045

1122. By Jeff Pihach on 2013-10-10

Adds charm icons to bundle token and detail view

R=gary.poster
CC=
https://codereview.appspot.com/14591044

1121. By Madison Scott-Clary on 2013-10-09

Fix upgrade text, remove feature flag

Upgrade service notification matches designs, feature flag for upgrade charm removed.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/14438061

1120. By Richard Harding on 2013-10-09

Prevent direct charm id routes mis-firing.

The routeDirectCharmId is ONLY meant to handle the case of short, id-only urls
"jujucharms.com/precise/mysql". It assumes the viewmode (usually 'sidebar').

A fullscreen url was getting processed except that the viewmode was set to
sidebar. This caused contention between the routeDirectCharmId and the
routeView which would work like this

- routeDirectCharmId: "Render this charm id I found in the url in sidebar mode"
- routeView: "We've rendered crap, but that was sidebar so Render this charm
id found in fullscreen"

--Enter double dispatch

- routeDirectCharmId: "Hmm, we've got crap rendered, but it was fullscreen so
the viewmode has changed. Render this charm id in sidebar"
- routeView: "Stupid sidebar, this clearly says to render it in fullscreen
viewmode. Render it again."

What should happen is that the routeDirectCharmId realizes that the url has
more than a charmId in it and just bails out saying another route (routeView)
will handle it altogether.

QA: Just hit the url in the bug in your local branch and it should work
perfectly without artifacts.

R=matthew.scott
CC=
https://codereview.appspot.com/14441054