Code review comment for lp://staging/~gary/juju-gui/bug1204331

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Fix subordinate behavior in Juju Core

The biggest change here is that we update service data with the charm
subordinate flag, because juju core does not include that information in
the service. This includes a test.

Other changes here are fly-by.
- The yui3-skin-sam class on the body was causing issues by adding
styles unnecessarily. I put it on the subapp-browser, where it is
sufficient.
- The sandbox sends is_subordinate, not subordinate, for charms. I'm
not sure if that is correct, but for now I changed charm.js to handle
it. I'd welcome opinions on pushing this back down into the pyjuju
sandbox, where I could test it. I'm kind of inclined to do that,
actually, but I want to get this branch proposed.
- I made a few changes to the inspector code to handle subordinates a
bit better, particularly in the ghost inspector. the ghost inspector
has no tests at all, and we have a card for adding them, so I did not
try to tack that effort on to this branch.
- I made a small tweak to charm-panel.js so that new services start
looking like subordinates immediately.
- I added a small hack that came in handy to track down behavior in a
handlebars template. Just add {{debugger}} in the template and you will
have a breakpoint there. handy. hopefully not too dangerous! We
definitely don't want to check in a template that uses this, and the
linter won't check our template code...

R=benji
CC=
https://codereview.appspot.com/11804043

https://codereview.appspot.com/11804043/

« Back to merge proposal