lp://staging/~gary/juju-gui/bug1204331
- Get this branch:
- bzr branch lp://staging/~gary/juju-gui/bug1204331
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 208 lines (+64/-11)10 files modifiedapp/index.html (+2/-2)
app/models/charm.js (+4/-1)
app/store/endpoints.js (+2/-0)
app/templates/ghost-config-wrapper.handlebars (+2/-0)
app/views/charm-panel.js (+2/-1)
app/views/environment.js (+2/-1)
app/views/ghost-inspector.js (+7/-3)
app/views/inspector.js (+6/-3)
app/views/utils.js (+12/-0)
test/test_endpoints.js (+25/-0)
Branch information
Recent revisions
- 886. By Richard Harding
-
TRIVIAL: Add raring to the filters.
- There are 6 raring packages undiscoverable currently due to there not being
a filter option to show them
- This adds that string.
- None of these are 'reviewed' so you must uncheck reviewed charms to see
them.
- This will go away when filters do, but was added as a quick favor to
~charmers so the raring ones are 'visible'. - 885. By Richard Harding
-
Move config.js into the HEAD of the body.
- Defer didn't help. Error still occurred.
- It's clear that the config.js either hadn't finished downloading or parsing.
- It can be run stand alone so moved to the head to get it up the request list
grouping. - 884. By Richard Harding
-
Force the order of execution of JS using defer.
- Defer allows the scripts to be downloaded async, however it *forces* the
browser to execute them in the order they appear in the DOM.
- There's a chance that we've had users hitting out of order execution between
this code causing Y.juju.App to not be defined during startTheApp. This should
force this to not occur.- Testing this just isn't possible. We're not 100% sure that it's the issue
and it's darn unrepeatable. The only repeatable case was a stale cache.
However, it has been demonstrated on machines in incognito mode so there is
something there. It's just very hard to reproduce.R=gary.poster
CC=
https://codereview. appspot. com/11571044 - 883. By Richard Harding
-
Break out left breakout panel from juju-inspector
- In order for items to be reused as a left-breakout they cannot be under the
.juju-inspector css tree or else it becomes a css nightmare.
- This restructures the default html layout so that the yui3-inspector-panel
is css agnostic and inside of it are the two main components, .juju-inspector
and the left breakout panel.
- The CharmDetails uses the left breakout panel and is situated to show inside
of that.
- Due to these changes some css needed tweaking.
- Anything that wants to reuse the .juju-inspector css rules in the left
breakout panel will have to add that css class to their own template output.QA:
To QA, run the gui with the serviceInspector flag and deploy a service. Then
click on that service to bring up the inspector and click on the cs:... url to
open the charm details view into the left breakout panel.R=bac, benji
CC=
https://codereview. appspot. com/11714043 - 882. By Gary Poster
-
Update service menus and enable for inspector
One of the last big issues remaining in the UX design to make the inspector usable was to make a disoverable way of creating relations. Luca and Ant worked together to revamp the existing popup menu for the purpose. This branch takes their design work and makes it work for both inspector and non-inspector uses. In order to have it work well, I had to update some of the calculations that determined where the menu was drawn.
R=benji, bac
CC=
https://codereview. appspot. com/11620043
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/juju-gui/experimental