LGTM nice improvements!
https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right):
https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js#newcode344 app/store/env/fakebackend.js:344: data.is_subordinate = data.subordinate; Ahh it was a naming mixup.
https://codereview.appspot.com/8812043/diff/1/test/utils.js File test/utils.js (right):
https://codereview.appspot.com/8812043/diff/1/test/utils.js#newcode62 test/utils.js:62: _cached_charms: (function() { Great idea
https://codereview.appspot.com/8812043/
« Back to merge proposal
LGTM nice improvements!
https:/ /codereview. appspot. com/8812043/ diff/1/ app/store/ env/fakebackend .js env/fakebackend .js (right):
File app/store/
https:/ /codereview. appspot. com/8812043/ diff/1/ app/store/ env/fakebackend .js#newcode344 env/fakebackend .js:344: data.is_subordinate =
app/store/
data.subordinate;
Ahh it was a naming mixup.
https:/ /codereview. appspot. com/8812043/ diff/1/ test/utils. js
File test/utils.js (right):
https:/ /codereview. appspot. com/8812043/ diff/1/ test/utils. js#newcode62
test/utils.js:62: _cached_charms: (function() {
Great idea
https:/ /codereview. appspot. com/8812043/