Code review comment for lp://staging/~gary/juju-gui/bug1167967

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Fix bug 1167967 (hopefully)

This branch attempts to fix the referenced bug. I was unable to
duplicate the symptoms locally exactly, but duplicated them closely
enough that I am optimistic that these changes address the issue.
Regardless, they seem like reasonable changes.

I also fixed a couple of landscape issues I saw with newly created
services without annotations.

The aspect of this branch I wonder most if reviewers (particularly Ben)
will like is the change to the route url algorithm. If it's not clear
why I chose it, I'm happy to discuss my rationale and other options.

Thank you.

R=bcsaller, matthew.scott
CC=
https://codereview.appspot.com/8680043

https://codereview.appspot.com/8680043/

« Back to merge proposal