lp://staging/~gary/juju-gui/bug1167967

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 540

Juju GUI Hackers: Pending requested 2013-04-11

Diff: 217 lines (+55/-25)

11 files modified

app/app.js (+1/-1)
app/assets/javascripts/ns-routing-app-extension.js (+3/-1)
app/views/charm.js (+1/-1)
app/views/landscape.js (+2/-1)
app/views/service.js (+2/-1)
app/views/utils.js (+16/-14)
test/test_app_hotkeys.js (+1/-1)
test/test_charm_view.js (+1/-1)
test/test_landscape.js (+15/-0)
test/test_routing.js (+6/-0)
test/test_service_view.js (+7/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1167967: The GUI hangs when a service is destroyed from the service detail view

High

Fix Released

Link a bug report

Related blueprints

540. By Gary Poster on 2013-04-11

fix problems deleting service from service view; fix issues with missing landscape annotations as a flyby.

539. By j.c.sackett on 2013-04-11

Adds "popular" charms to sidebar.

-Another block in sidebar creates the "popular" charm container.
-"Popular" charms also added to cache.
-"Popular" block added to sidebar template.
-Added "popular" to sidebar json test data, and re-pretty-printed it.
-Updated test for the additional charm in cache; although "popular" has two
charms, one of them (cassandra) is also in our "new" category.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8561048

538. By Richard Harding on 2013-04-11

Adjust design per review, add truncate helper

- Per UX reviews adjust some of the design of the browser
- Add a truncate handlebars helper to aid in fitting content nicely

R=j.c.sackett
CC=
https://codereview.appspot.com/8662043

537. By Gary Poster on 2013-04-11

Fix sandbox setconfig and associated test

The sandbox setconfig test was taking over a second--a pretty clear indication that it was waiting on the fake delta stream rather than a direct response. Investigation revealed that the sandbox method was incorrectly using the ASYNCOP helper rather than the OP helper. This small branch fixes the setconfig problem and adjusts the tests. The test is very fast now (not yellow or red in the mocha output).

R=bac, matthew.scott
CC=
https://codereview.appspot.com/8663043

536. By Madison Scott-Clary on 2013-04-11

Trivial: add relation works with touch.

R=gary.poster
CC=
https://codereview.appspot.com/8628044

535. By Francesco Banconi on 2013-04-11

Fix exposed attribute handling in delta stream

This branch fixes the service "exposed" and unit "relation_errors"
attributes handling when the delta comes from juju-core.
The _process_delta function allows for overriding those attrs
in the case a delta stream arrives from PyJuju. The juju-core
handlers, instead, must update model instances with partial changes,
e.g. when handling annotations. This was the cause of the regression.

Also improved the cleanUpEntityTags helper.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8657043

534. By Gary Poster on 2013-04-11

Fix bug 1166222

The Go environment is unwilling to load a charm before it is part of the environment, which broke our new endpoints implementation. Luckily, fixing it ended up being a nice cleanup on our side, I think. We do not need the charm until it is no longer a ghost.

R=teknico, frankban
CC=
https://codereview.appspot.com/8647043

533. By Gary Poster on 2013-04-10

Make safe relation ids in environment view

Relation ids included spaces and other problematic chacracters in our related DOM ids. This branch cleans those up, and also does a quick CSS cleanup to make some text legible again.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/8640043

532. By Richard Harding on 2013-04-10

Add UX styling to the sidebar and container UI

- Theme the containers
- Adjust the container to be clickable/toggleable thruogh the whole heading.
- Add the active state to the charms in the sidebar
- Adjust some of the CSS for the charm details to present in the sidebar view.

R=jeff.pihach
CC=
https://codereview.appspot.com/8618044

531. By j.c.sackett on 2013-04-10

Removes remaining references to charm slider

While the slider is gone, there were elements that still expected slider data;
sliderCharms, sliderContainers, and the slider class in the template.

All of these things are replaced by "featured" (e.g. featuredCharms), which is
the new container category replacing the slider in the design.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8600043