Code review comment for lp://staging/~gary-wzl77/ubuntu-rest-scopes/fix_1518888

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Interesting proposal, is this change considering the case of looking for
weather in another location?
In this case, shouldn't the scope pass some location argument to the
weather app?

A: Thanks for this suggestion, will have it in next MR update. The url
passed from weather scope to app will be as following:
weather://?display=hourly&city=London&lat=51.50853&lng=-0.12574
weather://?display=default&city=London&lat=51.50853&lng=-0.12574

On Wed, Jan 6, 2016 at 5:30 PM, David Callé <email address hidden> wrote:

> Interesting proposal, is this change considering the case of looking for
> weather in another location?
> In this case, shouldn't the scope pass some location argument to the
> weather app?
> --
>
> https://code.launchpad.net/~gary-wzl77/ubuntu-rest-scopes/fix_1518888/+merge/281720
> You are the owner of lp:~gary-wzl77/ubuntu-rest-scopes/fix_1518888.
>

--
Br
Gary.Wzl

« Back to merge proposal