Merge lp://staging/~gary-wzl77/ubuntu-rest-scopes/fix_1518888 into lp://staging/ubuntu-rest-scopes
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Adam Collard | ||||
| Proposed branch: | lp://staging/~gary-wzl77/ubuntu-rest-scopes/fix_1518888 | ||||
| Merge into: | lp://staging/ubuntu-rest-scopes | ||||
| Diff against target: |
161 lines (+35/-9) 2 files modified
src/scopes/tests/test_weatherchannel.py (+23/-5) src/scopes/weatherchannel.py (+12/-4) |
||||
| To merge this branch: | bzr merge lp://staging/~gary-wzl77/ubuntu-rest-scopes/fix_1518888 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu One hackers | Pending | ||
|
Review via email:
|
|||
Commit message
Weather app/scope usage fixed
1.When user clicks "hourly" button, it takes user from scope to weather app. And weather app displays hourly row on startup
2.Change "10 days forecast" to "5 days forecast"
3.When user clicks "5 days forecast" button, it takes user from scope to weather app. And weather app displays default weather graphic on startup
Note: This MR depends on
https:/
Description of the change
Weather app/scope usage fixed
1.When user clicks "hourly" button, it takes user from scope to weather app. And weather app displays hourly row on startup
2.Change "10 days forecast" to "5 days forecast"
3.When user clicks "5 days forecast" button, it takes user from scope to weather app. And weather app displays default weather graphic on startup
Note: This MR depends on
https:/
| David Callé (davidc3) wrote | # |
| Gary.Wang (gary-wzl77) wrote | # |
| Gary.Wang (gary-wzl77) wrote | # |
Unmerged revisions
- 495. By Gary.Wang
-
1.Add location arguments to have city weather view navigation in weather app
2.Fixed weather test case - 494. By Gary.Wang
-
Weather app/scope usage fixed
1.When user clicks "hourly" button, it takes user from scope to weather app. And weather app displays hourly row on startup
2.Change "10 days forecast" to "5 days forecast"
3.When user clicks "5 days forecast" button, it takes user from scope to weather app. And weather app displays default weather graphic on startup
Interesting proposal, is this change considering the case of looking for weather in another location?
In this case, shouldn't the scope pass some location argument to the weather app?