Code review comment for lp://staging/~gary-wzl77/net-cpp/reading_callback

Revision history for this message
James Henstridge (jamesh) wrote :

So they don't get lost, here's a summary of the issues I outlined in email:

1. Currently the libnet-cpp.so.2 soname essentially means "libnet-cpp.so.1 recompiled with the new C++11 ABI". If you are breaking the ABI of net-cpp, then the result should not be called libnet-cpp.so.1 _or_ libnet-cpp.so.2.

2. Following on from that, the library should still have different sonames on either side of the C++11 ABI break, so perhaps .so.3 on vivid and .so.4 on newer distros. It is possible to handle this kind of split with a single source tree going through citrain's dual landings via the bileto_pre_release_hook system. The mediascanner2 package is probably one of the simpler examples of this.

3. Replacing the net-cpp package on vivid is a no-go. It is part of the base image that Click packages depend on, and is explicitly part of the ubuntu-sdk-libs meta-package. The packages for the new and old net-cpp need to be able to co-exist in the archive, which means different source package names, and a different development package name.

« Back to merge proposal