Merge lp://staging/~gary-wzl77/net-cpp/reading_callback into lp://staging/net-cpp
Proposed by
Gary.Wang
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 50 | ||||
| Proposed branch: | lp://staging/~gary-wzl77/net-cpp/reading_callback | ||||
| Merge into: | lp://staging/net-cpp | ||||
| Diff against target: |
1342 lines (+717/-82) 21 files modified
CMakeLists.txt (+2/-2) debian/changelog (+13/-0) debian/control (+2/-6) debian/libnet-cpp1.symbols (+0/-47) debian/rules (+0/-8) include/core/net/http/client.h (+19/-0) include/core/net/http/method.h (+3/-1) include/core/net/http/request.h (+21/-0) include/core/net/http/streaming_client.h (+42/-0) include/core/net/http/streaming_request.h (+1/-0) src/core/net/http/impl/curl/client.cpp (+193/-2) src/core/net/http/impl/curl/client.h (+11/-0) src/core/net/http/impl/curl/easy.cpp (+23/-0) src/core/net/http/impl/curl/easy.h (+16/-2) src/core/net/http/impl/curl/multi.cpp (+5/-0) src/core/net/http/impl/curl/multi.h (+3/-0) src/core/net/http/impl/curl/request.h (+30/-1) tests/http_client_load_test.cpp (+1/-1) tests/http_client_test.cpp (+74/-1) tests/http_streaming_client_test.cpp (+251/-10) tests/httpbin.h.in (+7/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~gary-wzl77/net-cpp/reading_callback | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomas Voß | Pending | ||
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
Support data reading call back function in streaming API. That makes possible to upload data into the server directly without local cache.
Description of the change
Support data reading call back function in streaming API. That makes possible to upload data into server directly without local cache.
To post a comment you must log in.
Revision history for this message
| James Henstridge (jamesh) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
So they don't get lost, here's a summary of the issues I outlined in email:
1. Currently the libnet-cpp.so.2 soname essentially means "libnet-cpp.so.1 recompiled with the new C++11 ABI". If you are breaking the ABI of net-cpp, then the result should not be called libnet-cpp.so.1 _or_ libnet-cpp.so.2.
2. Following on from that, the library should still have different sonames on either side of the C++11 ABI break, so perhaps .so.3 on vivid and .so.4 on newer distros. It is possible to handle this kind of split with a single source tree going through citrain's dual landings via the bileto_
3. Replacing the net-cpp package on vivid is a no-go. It is part of the base image that Click packages depend on, and is explicitly part of the ubuntu-sdk-libs meta-package. The packages for the new and old net-cpp need to be able to co-exist in the archive, which means different source package names, and a different development package name.