Online Accounts: Account plugins

Code review comment for lp://staging/~gary-wzl77/account-plugins/onedrive_provider

onedrive_provider
Merge into trunk

Revision history for this message

Alberto Mardegan (mardy) wrote on 2016-10-14:

> Hi mandy
> Please check the following link
> https://msdn.microsoft.com/en-us/library/office/dn631819.aspx
>
> "Instead of using the Live SDK, you might want to try out the new OneDrive
> API. The OneDrive API is a RESTful API, that works directly with OneDrive, on
> many platforms, and *completely independent* of the Live SDK. This API
> provides a faster way to authenticate users, allows large file uploads, and
> more."

Yes, that's about the recommended API to use, but:

> Also you can find the onedrive oauth dev page here.
> https://dev.onedrive.com/auth/msa_oauth.htm

OneDrive is still using the Live account for authentication. Apart from a change in the scopes list, all other authentication parameters are the same. Given that in the future we might support other services provided by the Live account, it's not a good idea to refer to this provider as "onedrive".

> On the other hand, in order to easily to find "correct" account plugin
> from scopes/apps, I tend to use 'onedrive' as account plugin name, instead of
> "window live".
> As we have onedrive scope and storage provider here already.
> https://code.launchpad.net/storage-provider-onedrive
> https://code.launchpad.net/~hanloon-team/hanloon/onedrive_scope

Given that at the moment OneDrive is the only service we support for the Live account, I don't have any strong objections if you want to set the display name of the Live account to "OneDrive", so that users will find it more easily. However, the provider id should be not specific to OneDrive, but instead refer to Microsoft in general.

I now see that the Windows Live brand is actually discontinued [1], so even though the website is called live.com, it seems that Microsoft is trying to forget that name and instead call it just "Microsoft account", as in [2] and [3].
So, my suggestion is to use "microsoft" as provider ID.

[1] https://en.wikipedia.org/wiki/Windows_Live
[2] https://www.microsoft.com/en-us/account/
[3] https://login.live.com/login.srf

> Hi mandy
>     Please check the  following link
>     https://msdn.microsoft.com/en-us/library/office/dn631819.aspx
> 
>     "Instead of using the Live SDK, you might want to try out the new OneDrive
> API. The OneDrive API is a RESTful API, that works directly with OneDrive, on
> many platforms, and *completely independent* of the Live SDK. This API
> provides a faster way to authenticate users, allows large file uploads, and
> more."

Yes, that's about the recommended API to use, but:

>     Also you can find the onedrive oauth dev page here.
>     https://dev.onedrive.com/auth/msa_oauth.htm

>     On the other hand, in order to easily to find "correct" account plugin
> from scopes/apps, I tend to use 'onedrive' as account plugin name, instead of
> "window live".
>     As we have onedrive scope and storage provider here already.
>     https://code.launchpad.net/storage-provider-onedrive
>     https://code.launchpad.net/~hanloon-team/hanloon/onedrive_scope

[1] https://en.wikipedia.org/wiki/Windows_Live
[2] https://www.microsoft.com/en-us/account/
[3] https://login.live.com/login.srf

« Back to merge proposal