Merge lp://staging/~gary-wzl77/account-plugins/onedrive_provider into lp://staging/account-plugins
Proposed by
Gary.Wang
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alberto Mardegan | ||||
Approved revision: | 179 | ||||
Merged at revision: | 179 | ||||
Proposed branch: | lp://staging/~gary-wzl77/account-plugins/onedrive_provider | ||||
Merge into: | lp://staging/account-plugins | ||||
Diff against target: |
255 lines (+79/-41) 10 files modified
Makefile.am (+3/-2) configure.ac (+9/-9) data/providers/microsoft.provider.in.in (+26/-0) data/providers/windows-live.provider.in.in (+0/-26) debian/account-plugin-microsoft.install (+3/-0) debian/control (+8/-1) debian/rules (+2/-2) qml/Makefile.am (+1/-0) qml/microsoft/Main.qml (+27/-0) src/config.vapi (+0/-1) |
||||
To merge this branch: | bzr merge lp://staging/~gary-wzl77/account-plugins/onedrive_provider | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Mardegan (community) | Needs Fixing | ||
Review via email: mp+308236@code.staging.launchpad.net |
Commit message
Add onedrive account plugin.
Description of the change
Add onedrive account plugin.
Please find the onedrive scope at the following link for a quick review.
https:/
To post a comment you must log in.
Hi Gary! I think that the plugin should be called Windows Live, because OneDrive it's only one of its services.
We already had a Windows Live plugin, it got removed here: bazaar. launchpad. net/~online- accounts/ account- plugins/ trunk/revision/ 150
http://
but the file in data/providers/ facebook. provider. in.in is still there, so you can update it instead. plugin- windows- live," which is no longer relevant now.
You should also update the debian/control file to remove the line "Conflicts: account-