Merge lp://staging/~fs-8/selenium-simple-test/sst-remote-fixes into lp://staging/selenium-simple-test
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~fs-8/selenium-simple-test/sst-remote-fixes |
Merge into: | lp://staging/selenium-simple-test |
Diff against target: |
26 lines (+5/-3) 1 file modified
src/sst/scripts/remote.py (+5/-3) |
To merge this branch: | bzr merge lp://staging/~fs-8/selenium-simple-test/sst-remote-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Corey Goldberg (community) | Needs Fixing | ||
Review via email: mp+168557@code.staging.launchpad.net |
Description of the change
sst-remote, changes: correct command line parameter, switch parameters to browser factory
---------
Hi!
I was trying to use SST with a remote Selenium server for the first time (on my laptop, in a windows VM, to do cross-browser testing in IE). sst-remote didn't work for me and threw what was looking like simple oversight mistakes. I changed two lines of code and got SST-Remote working with a Selenium 2.33.0 server in a windows 8 env.
Maybe the python Selenium bindings API has been changed? Maybe this was broken for quite some time? I don't know!
HTH,
Flo
Unmerged revisions
- 421. By Florian Sesser
-
Make brackets/parens closing PEP-8 compliant
- 420. By Florian Sesser
-
Swap browser factory arguments into the order expected by Selenium 2.33.0
- 419. By Florian Sesser
-
Fix (presumably) typo in sst-remote
thanks for picking up that mistake.. you can see that sst.remote is neglected in terms of test coverage compared to the rest of sst :)
one small nitpick before merging this branch:
the way you have brackets/parens closed is not pep8 compliant, so it breaks our pep8 unit test.
can you fix up the closing brackets/parens and re-push to your branch?
it should be like:
browser_factory = browsers. RemoteBrowserFa ctory(
cmd_opts. webdriver_ remote_ url,
"browserNa me": cmd_opts. browser_ type.lower( ),
"platform" : cmd_opts. browser_ platform. upper() ,
"version" : cmd_opts. browser_ version,
"javascrip tEnabled" : not cmd_opts. javascript_ disabled, session_ name,
{
"name": cmd_opts.
},
)
regards,
-Corey