thanks for picking up that mistake.. you can see that sst.remote is neglected in terms of test coverage compared to the rest of sst :)
one small nitpick before merging this branch:
the way you have brackets/parens closed is not pep8 compliant, so it breaks our pep8 unit test.
can you fix up the closing brackets/parens and re-push to your branch?
thanks for picking up that mistake.. you can see that sst.remote is neglected in terms of test coverage compared to the rest of sst :)
one small nitpick before merging this branch:
the way you have brackets/parens closed is not pep8 compliant, so it breaks our pep8 unit test.
can you fix up the closing brackets/parens and re-push to your branch?
it should be like:
browser_factory = browsers. RemoteBrowserFa ctory(
cmd_opts. webdriver_ remote_ url,
"browserNa me": cmd_opts. browser_ type.lower( ),
"platform" : cmd_opts. browser_ platform. upper() ,
"version" : cmd_opts. browser_ version,
"javascrip tEnabled" : not cmd_opts. javascript_ disabled, session_ name,
{
"name": cmd_opts.
},
)
regards,
-Corey