Code review comment for lp://staging/~flexiondotorg/ubuntu-themes/ubuntu-themes-gtktoolbutton-lp1641915-xenial

I don't understand this change, can you please elaborate?

The rules already have

  .inline-toolbar.toolbar .button:first-child,

...etc selectors.

So can you tell me what you're trying to achieve here? As far as I can see what's happening after this change is that the ".button:only-child" rule always applies, because the GtkButton is always the only child of the GtkToolButton and there's now no more specific rule to apply the first/last styles.

I think there's a problem with the "middle" button rules, probably. They are supposed to look 'merged' but they don't. It seems like the "Single button" rules are being applied instead of the "Middle button" ones, so probably something to do with the selectors.

BTW, when this is fixed, we need to update trunk too so it stays backportable.