Merge lp://staging/~flexiondotorg/ubuntu-themes/ubuntu-themes-gtktoolbutton-lp1641915-xenial into lp://staging/ubuntu-themes/xenial
Proposed by
Martin Wimpress
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~flexiondotorg/ubuntu-themes/ubuntu-themes-gtktoolbutton-lp1641915-xenial | ||||
| Merge into: | lp://staging/ubuntu-themes/xenial | ||||
| Diff against target: |
133 lines (+42/-42) 2 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+21/-21) Radiance/gtk-3.0/gtk-widgets.css (+21/-21) |
||||
| To merge this branch: | bzr merge lp://staging/~flexiondotorg/ubuntu-themes/ubuntu-themes-gtktoolbutton-lp1641915-xenial | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Iain Lane (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Correct GtkToolButton first-child, only-child and last-child styling to prevent buttons clipping/
To post a comment you must log in.
Revision history for this message
| Amr Ibrahim (amribrahim1987) wrote | # |
Unmerged revisions
- 487. By Martin Wimpress
-
Correct GtkToolButton first-child, only-child and last-child styling to
prevent buttons clipping/overlapping in GNOME Disks and Ubiquity disk
partioner. (LP: #1641915)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I don't understand this change, can you please elaborate?
The rules already have
.inline-
...etc selectors.
So can you tell me what you're trying to achieve here? As far as I can see what's happening after this change is that the ".button:
I think there's a problem with the "middle" button rules, probably. They are supposed to look 'merged' but they don't. It seems like the "Single button" rules are being applied instead of the "Middle button" ones, so probably something to do with the selectors.
BTW, when this is fixed, we need to update trunk too so it stays backportable.