Code review comment for lp://staging/~fginther/ubuntu-ci-services-itself/fix-get-binaries

Revision history for this message
Francis Ginther (fginther) wrote :

> that looks like my IRC comment. You've pulled a Chris Johnson, you take
> something I said and put it in an MP. It makes it impossible for me to
> disagree with :)

I got tired of always being wrong, so I figured the best way was to start by agreeing with someone who knows better...

Also came back and fixed the tests that needed to be updated to generate a dict instead of a list for the mocked get_binaries() method.

review: Needs Resubmitting

« Back to merge proposal