Ubuntu CI Services

Merge lp://staging/~fginther/ubuntu-ci-services-itself/fix-get-binaries into lp://staging/ubuntu-ci-services-itself

fix-get-binaries
Merge into trunk

Proposed by Francis Ginther on 2014-03-14

Status:

Merged

Approved by:

Chris Johnston on 2014-03-14

Approved revision:

386

Merged at revision:

386

Proposed branch:

lp://staging/~fginther/ubuntu-ci-services-itself/fix-get-binaries

Merge into:

lp://staging/ubuntu-ci-services-itself

Diff against target:

64 lines (+15/-6)

2 files modified

lander/bin/lander_service_wrapper.py (+1/-1)
lander/lander/tests/test_service_wrapper.py (+14/-5)

To merge this branch:

bzr merge lp://staging/~fginther/ubuntu-ci-services-itself/fix-get-binaries

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Chris Johnston (community)			Approve on 2014-03-14
PS Jenkins bot (community)	continuous-integration		Approve on 2014-03-14
Francis Ginther			Needs Resubmitting on 2014-03-14
Andy Doan (community)		2014-03-14	Approve on 2014-03-14
Review via email: mp+210941@code.staging.launchpad.net

Commit message

The ticket binaries API returns a dict, not a list.

Description of the change

The ticket binaries API returns a dict, not a list.

Tested here: http://15.125.89.9/ticket.html?ticket_id=3
The third ticket used a binary specified in the prior ticket.

Revision history for this message

Andy Doan (doanac) wrote on 2014-03-14:

that looks like my IRC comment. You've pulled a Chris Johnson, you take something I said and put it in an MP. It makes it impossible for me to disagree with :)

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-14:

FAILED: Continuous integration, rev:385
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/415/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/415/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~fginther/ubuntu-ci-services-itself/fix-get-binaries updated on 2014-03-14

386. By Francis Ginther on 2014-03-14: Update the tests to also use a dict for the list of golden packages.

Revision history for this message

Francis Ginther (fginther) wrote on 2014-03-14:

> that looks like my IRC comment. You've pulled a Chris Johnson, you take
> something I said and put it in an MP. It makes it impossible for me to
> disagree with :)

I got tired of always being wrong, so I figured the best way was to start by agreeing with someone who knows better...

Also came back and fixed the tests that needed to be updated to generate a dict instead of a list for the mocked get_binaries() method.

review: Needs Resubmitting

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-14:

PASSED: Continuous integration, rev:386
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/417/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/417/rebuild