Code review comment for lp://staging/~eyelash/plank/xshape

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Looks fine so far.

The else-path in composited_changed is not needed.

What is suppose to happen if the theme defines a huge corner-radius? It will result in cut off icons this way.

review: Needs Fixing

« Back to merge proposal