Plank

Merge lp://staging/~eyelash/plank/xshape into lp://staging/plank

  1. xshape
  2. Merge into trunk
Proposed by eyelash
Status: Needs review
Proposed branch: lp://staging/~eyelash/plank/xshape
Merge into: lp://staging/plank
Diff against target: 47 lines (+13/-4)
2 files modified
lib/DockRenderer.vala (+13/-1)
lib/Drawing/Theme.vala (+0/-3)
To merge this branch: bzr merge lp://staging/~eyelash/plank/xshape
Reviewer Review Type Date Requested Status
Rico Tzschichholz Needs Fixing
Review via email: mp+208462@code.staging.launchpad.net

Commit message

support rounded corners in non-composited environments

Description of the change

support rounded corners in non-composited environments

Note that I'm not familiar with the plank codebase so there might be some issues that I don't know about.

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Looks fine so far.

The else-path in composited_changed is not needed.

What is suppose to happen if the theme defines a huge corner-radius? It will result in cut off icons this way.

review: Needs Fixing
Reply
Revision history for this message
eyelash (eyelash) wrote :

> The else-path in composited_changed is not needed.

So you mean the background_buffer is reset to null if compositing is disabled?

> What is suppose to happen if the theme defines a huge corner-radius? It will
> result in cut off icons this way.

I will need to find a solution for that.
I just figured another possible problem: The case that a theme defines a background colour with less than 50% opacity.

Reply
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

> > The else-path in composited_changed is not needed.
>
> So you mean the background_buffer is reset to null if compositing is disabled?

Not directly, but in the end, yes. So the second call will take care of that.

> > What is suppose to happen if the theme defines a huge corner-radius? It will
> > result in cut off icons this way.
>
> I will need to find a solution for that.
> I just figured another possible problem: The case that a theme defines a
> background colour with less than 50% opacity.

Right, that is a problem too.

Reply

Unmerged revisions

1001. By eyelash

remove a leftover debug message

1000. By eyelash

support rounded corners in non-composited environments

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: