I found the diff unhelpful in reviewing the code so I just looked at rebuild_bucketversions.py in your branch, hence my not replying to the merge proposal.
> def repair_sas(key, o):
> '''Back at the January sprint, Martin found and fixed a bug that was
> preventing the SAS from being generated. There are at least 796,000 reports
> in the database that are missing one. Repair them, if possible.'''
>
> report = apport.Report()
report is already setup in main so you could just pass it to repair_sas. Additionally, the sprint was in December. ;-)
I also found the location of idx_key, crash_sigs, …, kwargs to be odd. Otherwise, this looks good me.
I found the diff unhelpful in reviewing the code so I just looked at rebuild_ bucketversions. py in your branch, hence my not replying to the merge proposal.
> def repair_sas(key, o):
> '''Back at the January sprint, Martin found and fixed a bug that was
> preventing the SAS from being generated. There are at least 796,000 reports
> in the database that are missing one. Repair them, if possible.'''
>
> report = apport.Report()
report is already setup in main so you could just pass it to repair_sas. Additionally, the sprint was in December. ;-)
I also found the location of idx_key, crash_sigs, …, kwargs to be odd. Otherwise, this looks good me.