Merge lp://staging/~ev/daisy/bucket-versions into lp://staging/daisy

Proposed by Evan
Status: Merged
Approved by: Brian Murray
Approved revision: 312
Merged at revision: 315
Proposed branch: lp://staging/~ev/daisy/bucket-versions
Merge into: lp://staging/daisy
Diff against target: 0 lines
To merge this branch: bzr merge lp://staging/~ev/daisy/bucket-versions
Reviewer Review Type Date Requested Status
Daisy Pluckers Pending
Review via email: mp+158948@code.staging.launchpad.net

Description of the change

This is the back-population script for https://code.launchpad.net/~ev/oops-repository/bucket-versions/+merge/158946.

It keeps track of the various types of problems that we haven't been able to generate a bucket identifier for, as it's proven useful to investigate these further (I used this script as the basis for lp:~ev/daisy/refactor-submission).

It tries to rebuild the StacktraceAddressSignature when it's missing, and inserts that back into the OOPS CF.

Its primary use though, is to come up with a crash signature for each report and then update the release and binary package versions that bucket has been seen for.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I found the diff unhelpful in reviewing the code so I just looked at rebuild_bucketversions.py in your branch, hence my not replying to the merge proposal.

> def repair_sas(key, o):
> '''Back at the January sprint, Martin found and fixed a bug that was
> preventing the SAS from being generated. There are at least 796,000 reports
> in the database that are missing one. Repair them, if possible.'''
>
> report = apport.Report()

report is already setup in main so you could just pass it to repair_sas. Additionally, the sprint was in December. ;-)

I also found the location of idx_key, crash_sigs, …, kwargs to be odd. Otherwise, this looks good me.

313. By Evan

Don't process into an apport report twice. Thanks Brian.

314. By Evan

Move globals up to the top.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: