1) I assume you're wanting to land this for a staging/production re-roll? In which case, are you going to land it on trunk, but then also on a separate 11.02 branch cut from r171 (as there have been new revs landed since then)? Or are you happy to include those other changes in the re-roll (we should QA them well on the daily server first)
2) It'd be great to include a test that shows the exception traceback actually in the oops report... unfortunately it's in a post 11.02 revision that such tests landed, so you can't update those unless you are including r172 in the re-roll... maybe it's worth it? See what you think (you could then add a test that shows a 500 request resulting with an oops on disk including the traceback?)
A few questions:
1) I assume you're wanting to land this for a staging/production re-roll? In which case, are you going to land it on trunk, but then also on a separate 11.02 branch cut from r171 (as there have been new revs landed since then)? Or are you happy to include those other changes in the re-roll (we should QA them well on the daily server first)
2) It'd be great to include a test that shows the exception traceback actually in the oops report... unfortunately it's in a post 11.02 revision that such tests landed, so you can't update those unless you are including r172 in the re-roll... maybe it's worth it? See what you think (you could then add a test that shows a 500 request resulting with an oops on disk including the traceback?)