Merge lp://staging/~elachuni/rnr-server/log-exceptions into lp://staging/rnr-server
Proposed by
Anthony Lenton
| Status: | Merged |
|---|---|
| Approved by: | Łukasz Czyżykowski |
| Approved revision: | 174 |
| Merged at revision: | 175 |
| Proposed branch: | lp://staging/~elachuni/rnr-server/log-exceptions |
| Merge into: | lp://staging/rnr-server |
| Diff against target: |
250 lines (+199/-2) 4 files modified
.bzrignore (+1/-0) django_project/config_dev/config/main.cfg (+1/-1) src/reviewsapp/middleware/exception.py (+111/-0) src/reviewsapp/tests/test_middleware.py (+86/-1) |
| To merge this branch: | bzr merge lp://staging/~elachuni/rnr-server/log-exceptions |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Nelson (community) | Needs Information | ||
|
Review via email:
|
|||
Commit message
[r=lukasz] Add code to get tracebacks in the oops reports.
Description of the change
Overview
========
Add our LogExceptionMid
Details
=======
All code in this branch (including the tests) has been already tested and deployed to production on other projects.
To post a comment you must log in.
Revision history for this message
| Michael Nelson (michael.nelson) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
A few questions:
1) I assume you're wanting to land this for a staging/production re-roll? In which case, are you going to land it on trunk, but then also on a separate 11.02 branch cut from r171 (as there have been new revs landed since then)? Or are you happy to include those other changes in the re-roll (we should QA them well on the daily server first)
2) It'd be great to include a test that shows the exception traceback actually in the oops report... unfortunately it's in a post 11.02 revision that such tests landed, so you can't update those unless you are including r172 in the re-roll... maybe it's worth it? See what you think (you could then add a test that shows a 500 request resulting with an oops on disk including the traceback?)