Code review comment for lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Hi Daniel,
thanks! I think this module should be moved to a community project now, maybe server-env-tools?
Pending that, I'd like to suggest for l.9 to please use at least two digit version numbers, to eventually be able to follow the convention of different levels for version or features, and one for minor changes.
Looks good otherwise. Please claim your credits with an additional "(C) 2013" and @author mention in the python files