Merge lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr into lp://staging/~therp-nl/therp-addons/7.0

Proposed by Daniel Reis
Status: Rejected
Rejected by: Stefan Rijnhart (Opener)
Proposed branch: lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr
Merge into: lp://staging/~therp-nl/therp-addons/7.0
Diff against target: 208 lines (+39/-50)
7 files modified
users_ldap_groups/__openerp__.py (+6/-8)
users_ldap_groups/users_ldap_groups.py (+3/-3)
users_ldap_groups/users_ldap_groups.xml (+17/-27)
users_ldap_populate/__openerp__.py (+3/-3)
users_ldap_populate/model/users_ldap.py (+3/-3)
users_ldap_populate/view/populate_wizard.xml (+6/-5)
users_ldap_populate/view/users_ldap.xml (+1/-1)
To merge this branch: bzr merge lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) (community) Needs Fixing
Review via email: mp+176166@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Daniel,

thanks! I think this module should be moved to a community project now, maybe server-env-tools?

Pending that, I'd like to suggest for l.9 to please use at least two digit version numbers, to eventually be able to follow the convention of different levels for version or features, and one for minor changes.

Looks good otherwise. Please claim your credits with an additional "(C) 2013" and @author mention in the python files

review: Needs Fixing
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Oh, I was not explicit enough in my review but I would like it if you could propose this module to a community project, replacing this proposal.

81. By Daniel Reis (<email address hidden>)

FIX use orm instead of osv

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Hi Stefan,

It's good to know you agree to "donate" these modules to the Community.
I'll also port the `users_ldap_groups` and, if you agree, will propose them both for server-env-tools.

Regarding authorship, I think it's too much for me to claim for that when I'm only doing a small contribution.
Actually this is an interesting question for OCA: when should a contributor be added to the author list (if that still makes sense under OCA contribution agreement), and should contributors be given credit. But that's another discussion ...

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Daniel,

IMHO upgrading and testing any module under a new OpenERP major release is a substantial and valuable work that should be credited, but you may do as you see fit yourself, obviously ;-)

We are happy to hear that users_ldap_groups is useful to you too and looking forward to seeing that one proposed in a community project.

82. By Daniel Reis (<email address hidden>)

FIX version number

83. By Daniel Reis (<email address hidden>)

PORT module users_ldap_groups to v7

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Rejecting this proposal because of follow up proposal on other project: https://code.launchpad.net/~dreis-pt/server-env-tools/7.0-port-users-ldap/+merge/176355

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Stephan: these modules should be removed from your 7.0 branch then.
Or maybe leave them with only an inactive __openerp__.py file informing where the modules moved to.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Unmerged revisions

83. By Daniel Reis (<email address hidden>)

PORT module users_ldap_groups to v7

82. By Daniel Reis (<email address hidden>)

FIX version number

81. By Daniel Reis (<email address hidden>)

FIX use orm instead of osv

80. By Daniel Reis (<email address hidden>)

PORT users_ldap_populate from 6.1 to 7

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: