Merge lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr into lp://staging/~therp-nl/therp-addons/7.0
Proposed by
Daniel Reis
Status: | Rejected |
---|---|
Rejected by: | Stefan Rijnhart (Opener) |
Proposed branch: | lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr |
Merge into: | lp://staging/~therp-nl/therp-addons/7.0 |
Diff against target: |
208 lines (+39/-50) 7 files modified
users_ldap_groups/__openerp__.py (+6/-8) users_ldap_groups/users_ldap_groups.py (+3/-3) users_ldap_groups/users_ldap_groups.xml (+17/-27) users_ldap_populate/__openerp__.py (+3/-3) users_ldap_populate/model/users_ldap.py (+3/-3) users_ldap_populate/view/populate_wizard.xml (+6/-5) users_ldap_populate/view/users_ldap.xml (+1/-1) |
To merge this branch: | bzr merge lp://staging/~dreis-pt/therp-addons/7.0-port-users_ldap_populate-dr |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefan Rijnhart (Opener) (community) | Needs Fixing | ||
Review via email: mp+176166@code.staging.launchpad.net |
To post a comment you must log in.
Hi Daniel,
thanks! I think this module should be moved to a community project now, maybe server-env-tools?
Pending that, I'd like to suggest for l.9 to please use at least two digit version numbers, to eventually be able to follow the convention of different levels for version or features, and one for minor changes.
Looks good otherwise. Please claim your credits with an additional "(C) 2013" and @author mention in the python files