Code review comment for lp://staging/~dreis-pt/project-service/7.0-project_issue_reassign-dr

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Just some nitpickings:

l.419
self.pool.get('project.issue') can be written self.pool['project.issue']

l.421-422
assign_to.user_id and assign_to.user_id.id or None

can simply be written

assign_to.user_id.id

As assign_to.user_id if not defined will return browse_null and browse_null.id will return None

http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/osv/orm.py#L266

Otherwise LGTM

(can't check pt.po)

review: Needs Fixing (code review, no test)

« Back to merge proposal