Project for Service Management

Merge lp://staging/~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp://staging/~project-core-editors/project-service/trunk

7.0-project_issue_reassign-dr
Merge into trunk

Proposed by Daniel Reis on 2013-11-14

Status:	Needs review
Proposed branch:	lp://staging/~dreis-pt/project-service/7.0-project_issue_reassign-dr
Merge into:	lp://staging/~project-core-editors/project-service/trunk
Diff against target:	474 lines (+422/-0) 10 files modified project_issue_reassign/__init__.py (+3/-0) project_issue_reassign/__openerp__.py (+54/-0) project_issue_reassign/i18n/project_issue_reassign.pot (+82/-0) project_issue_reassign/i18n/pt.po (+82/-0) project_issue_reassign/project.py (+48/-0) project_issue_reassign/project_issue_data.xml (+24/-0) project_issue_reassign/project_issue_view.xml (+33/-0) project_issue_reassign/wizard/__init__.py (+2/-0) project_issue_reassign/wizard/project_issue_reassign.py (+48/-0) project_issue_reassign/wizard/project_issue_reassign_view.xml (+46/-0)
To merge this branch:	bzr merge lp://staging/~dreis-pt/project-service/7.0-project_issue_reassign-dr
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Pedro Manuel Baeza	code review		Needs Fixing on 2014-05-25
Yannick Vaucher @ Camptocamp	code review, no test	2013-11-14	Needs Fixing on 2014-05-14
Review via email: mp+195275@code.staging.launchpad.net

Description of the change

Module to improve Issue reassignment to other Projects or Users.

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2013-12-27:

I found possible usability issues, so I'0m setting to "Work in Progress" while I investigate.

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-04-03:

It's ready to be reviewed.
A new feature was added, to generate a notification when the Issue's responsibility changes.

Revision history for this message

Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote on 2014-05-14:

Just some nitpickings:

l.419
self.pool.get('project.issue') can be written self.pool['project.issue']

l.421-422
assign_to.user_id and assign_to.user_id.id or None

can simply be written

assign_to.user_id.id

As assign_to.user_id if not defined will return browse_null and browse_null.id will return None

http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/osv/orm.py#L266

Otherwise LGTM

(can't check pt.po)

review: Needs Fixing (code review, no test)

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-05-25:

Hi, Daniel, thank you very much for your contrib. Some remarks:

- l.400, please put orm.TransientModel instead of osv, for better future compatibility (and change accordingly import).
- Please use CapsWords convention for class names as agreed not long ago.

The rest LGTM.

Regards.

review: Needs Fixing (code review)

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-07-01:

This project is now hosted on https://github.com/OCA/project-service. Please move your proposal there.
This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

29. By Daniel Reis on 2014-04-02: Added notifications when assigned user changes.
28. By Daniel Reis on 2013-11-14: Added module to improve Issue reassignment to other Projects or Users