Code review comment for lp://staging/~dreis-pt/department-mgmt/analytic-v7

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Thank you - I'm just applying what I learned in other MP reviews.

I'm fixing the +x attributes, and I'll be adding my name to the authors list as you kindly suggested.
I tried with the list, but it just gets converted to a string, so it's best not to the list.

As for the license text, IMHO it's rather pointless to repeat it in every .py file, including empty __init__.py files. And the license is ment to apply to all files, not only python code. I have seen that newer modules include a LICENSE text file for this, and I think that a DRYer single license file makes more sense.

I'll be resubmitting the changes soon.

« Back to merge proposal