Merge lp://staging/~dreis-pt/department-mgmt/analytic-v7 into lp://staging/~department-core-editors/department-mgmt/7.0

Very good styling, this could serve as an example for us all!

I'd like to point out you are adding +x attributes (executable) on each file? Are you perhaps using bzr under windows? Is there any way you can avoid passing this in the commit ?

Also feel free I'd say to add yourself to the authors by converting it to a list of strings:
"author": ["Camptocamp", "Daniel Reis"],

Perhaps even the copyright section can be expanded to include your name and the current year.

Thank you - I'm just applying what I learned in other MP reviews.

I'm fixing the +x attributes, and I'll be adding my name to the authors list as you kindly suggested.
I tried with the list, but it just gets converted to a string, so it's best not to the list.

As for the license text, IMHO it's rather pointless to repeat it in every .py file, including empty __init__.py files. And the license is ment to apply to all files, not only python code. I have seen that newer modules include a LICENSE text file for this, and I think that a DRYer single license file makes more sense.

I'll be resubmitting the changes soon.

Just pushed the changes into the MP.

Nit picking : I believe Joël's last name is correctly spelled 'Grand-Guillaume" (with two capital "G"s).

Apart from that LGTM.

Don't want to mess with Joël - fixed.

For that author field, I know inside OpenERP it's listed as simple repr() output but I think it's correctly parsed and assigned on the openerp apps (and it's future proof too). It still is a better way imho to indicate who worked on it instead of concatenating all the author names together inside and unbreakable string.

Oh, I saw that you proposed the module 2 times, here and in this branch: https://code.launchpad.net/~dreis-pt/department-mgmt/project-v7b/+merge/151006

I guess that this merge proposal is a pre-requisite for the other one, next time, in such case can you resubmit the 'project-v7b/+merge/151006' putting this branch as 'pre-requisite' please? Thus, the changes of this branch won't be displayed on the other one. Thanks

Same remark than the other merge proposal, the <field name="type">...</field> is now useless in v7, they can be removed.

Fixed!

Thanks! LGTM