Merge lp://staging/~dreis-pt/department-mgmt/analytic-v7 into lp://staging/~department-core-editors/department-mgmt/7.0
Proposed by
Daniel Reis
Status: | Merged |
---|---|
Merged at revision: | 10 |
Proposed branch: | lp://staging/~dreis-pt/department-mgmt/analytic-v7 |
Merge into: | lp://staging/~department-core-editors/department-mgmt/7.0 |
Diff against target: |
314 lines (+61/-174) 5 files modified
analytic_department/LICENSE (+18/-0) analytic_department/__init__.py (+0/-31) analytic_department/__openerp__.py (+10/-50) analytic_department/analytic.py (+7/-49) analytic_department/analytic_view.xml (+26/-44) |
To merge this branch: | bzr merge lp://staging/~dreis-pt/department-mgmt/analytic-v7 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guewen Baconnier @ Camptocamp | Approve | ||
Alexandre Fayolle - camptocamp | code review, no test | Approve | |
Niels Huylebroeck (community) | no test | Approve | |
Review via email: mp+150798@code.staging.launchpad.net |
Description of the change
Migrated analytic_department to v7.
I chose to remove the features depending on the deprecated user department.
To post a comment you must log in.
Very good styling, this could serve as an example for us all!
I'd like to point out you are adding +x attributes (executable) on each file? Are you perhaps using bzr under windows? Is there any way you can avoid passing this in the commit ?
Also feel free I'd say to add yourself to the authors by converting it to a list of strings:
"author": ["Camptocamp", "Daniel Reis"],
Perhaps even the copyright section can be expanded to include your name and the current year.