Code review comment for lp://staging/~dreamhosters/txaws/921349-get-bucket-logging-method

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

[1] So, it looks like you've used the wrong payload for this branch? You're getting Status from "VersioningConfiguration"...

The XML payload you're really going to be looking at is this one:

<?xml version="1.0" encoding="UTF-8"?>
<BucketLoggingStatus xmlns="http://doc.s3.amazonaws.com/2006-03-01">
  <LoggingEnabled>
    <TargetBucket>mybucketlogs</TargetBucket>
    <TargetPrefix>mybucket-access_log-/</TargetPrefix>
    <TargetGrants>
      <Grant>
        <Grantee xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:type="AmazonCustomerByEmail">
          <EmailAddress><email address hidden></EmailAddress>
        </Grantee>
        <Permission>READ</Permission>
      </Grant>
    </TargetGrants>
  </LoggingEnabled>
</BucketLoggingStatus>

Or this:

<BucketLoggingStatus xmlns="http://doc.s3.amazonaws.com/2006-03-01" />

The former (obviously) needing more modeling than just setting a status attribute ;-)

review: Needs Fixing

« Back to merge proposal