txAWS

Merge lp://staging/~dreamhosters/txaws/921349-get-bucket-logging-method into lp://staging/txaws

921349-get-bucket-logging-method
Merge into trunk

Proposed by Arsene Rei on 2012-01-27

Status:

Merged

Merged at revision:

130

Proposed branch:

lp://staging/~dreamhosters/txaws/921349-get-bucket-logging-method

Merge into:

lp://staging/txaws

Diff against target:

198 lines (+150/-1)

4 files modified

txaws/s3/client.py (+20/-1)
txaws/s3/model.py (+8/-0)
txaws/s3/tests/test_client.py (+109/-0)
txaws/testing/payload.py (+13/-0)

To merge this branch:

bzr merge lp://staging/~dreamhosters/txaws/921349-get-bucket-logging-method

Low

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Duncan McGreggor		2012-01-27	Needs Fixing on 2012-01-27
Review via email: mp+90540@code.staging.launchpad.net

Description of the change

Add GET Bucket logging functionality.

Revision history for this message

Duncan McGreggor (oubiwann) wrote on 2012-01-27:

[1] So, it looks like you've used the wrong payload for this branch? You're getting Status from "VersioningConfiguration"...

The XML payload you're really going to be looking at is this one:

<?xml version="1.0" encoding="UTF-8"?>
<BucketLoggingStatus xmlns="http://doc.s3.amazonaws.com/2006-03-01">
  <LoggingEnabled>
    <TargetBucket>mybucketlogs</TargetBucket>
    <TargetPrefix>mybucket-access_log-/</TargetPrefix>
    <TargetGrants>
      <Grant>
        <Grantee xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:type="AmazonCustomerByEmail">
          <EmailAddress><email address hidden></EmailAddress>
        </Grantee>
        <Permission>READ</Permission>
      </Grant>
    </TargetGrants>
  </LoggingEnabled>
</BucketLoggingStatus>

Or this:

The former (obviously) needing more modeling than just setting a status attribute ;-)

review: Needs Fixing

lp://staging/~dreamhosters/txaws/921349-get-bucket-logging-method updated on 2012-01-27

136. By Arsene Rei on 2012-01-27

change get bucket logging tests to correct versioning ones

I looked at the wrong bug when I first create the branch which led to me
call everything logging.

137. By Arsene Rei on 2012-01-27

make further modifications for logging to versioning

* LoggingStatus -> VersioningConfiguration
* Rename some testing methods
* Fix some tests

Revision history for this message

Arsene Rei (arsene-rei) wrote on 2012-01-28:

I think bzr/lp is smart and recognizes that this was merged as part of another set of commits. I had not taken the wrong payload. Rather, I had begun referencing the wrong bug! >.<