unity-scope-click

Code review comment for lp://staging/~dobey/unity-scope-click/require-both

  1. require-both
  2. Merge into trunk
Revision history for this message
Paweł Stołowski (stolowski) wrote :

30 + Review existing_review;
31 if (has_reviewed) {

Review will not get initialized here and if has_reviewed is false it may have random id in review.id != 0 check inside createRatingWidget. Please change it to "Review existing_review {}" or initialize it to sane defaults manually.

Otherwise looks good.

review: Needs Fixing

« Back to merge proposal