unity-scope-click

Merge lp://staging/~dobey/unity-scope-click/require-both into lp://staging/unity-scope-click

  1. require-both
  2. Merge into trunk
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 453
Merged at revision: 457
Proposed branch: lp://staging/~dobey/unity-scope-click/require-both
Merge into: lp://staging/unity-scope-click
Diff against target: 99 lines (+40/-13)
3 files modified
libclickscope/click/preview.cpp (+19/-12)
libclickscope/click/preview.h (+2/-1)
libclickscope/tests/test_preview.cpp (+19/-0)
To merge this branch: bzr merge lp://staging/~dobey/unity-scope-click/require-both
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Needs Fixing
Antti Kaijanmäki (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+295511@code.staging.launchpad.net

Commit message

Don't specify that only 'rating' as required for reviews.

To post a comment you must log in.
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

LGTM.

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) wrote :

30 + Review existing_review;
31 if (has_reviewed) {

Review will not get initialized here and if has_reviewed is false it may have random id in review.id != 0 check inside createRatingWidget. Please change it to "Review existing_review {}" or initialize it to sane defaults manually.

Otherwise looks good.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: