Code review comment for lp://staging/~debbie-beliveau/ubuntu/maverick/ubiquity/ubiquity-depends-fix

Revision history for this message
Matt Zimmerman (mdz) wrote :

perl-modules is declared as a Suggests of adduser. This means that perl-modules is "related" to the depending package and "can perhaps enhance its usefulness, but that installing this one without them is perfectly reasonable."

Since basic deluser functionality works without perl-modules, I think this is accurate. perl-modules is only required for --remove-home. I am surprised if ubiquity doesn't depend on perl somewhere in its dependency chain, but technically ubiquity should probably depend on perl if it requires this functionality.

Suggestions:
- Revise the comment and changelog with regard to the perl-modules dependency
- Consider using plain deluser (without --remove-home) instead of userdel, since they have different behavior (and could diverge more in the future)

« Back to merge proposal