Merge lp://staging/~debbie-beliveau/ubuntu/maverick/ubiquity/ubiquity-depends-fix into lp://staging/ubuntu/maverick/ubiquity

Proposed by Debbie Beliveau
Status: Needs review
Proposed branch: lp://staging/~debbie-beliveau/ubuntu/maverick/ubiquity/ubiquity-depends-fix
Merge into: lp://staging/ubuntu/maverick/ubiquity
Diff against target: 46 lines (+15/-2)
3 files modified
bin/oem-config-wrapper (+5/-1)
debian/changelog (+9/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp://staging/~debbie-beliveau/ubuntu/maverick/ubiquity/ubiquity-depends-fix
Reviewer Review Type Date Requested Status
Evan Pending
Review via email: mp+28255@code.staging.launchpad.net

Description of the change

Cleans up runtime dependencies by removing (unspecified) dependency on perl-modules and specifying dependency on wget. userdel change already reviewed by Martin Pitt (though "|| true" portion of change was added after his review).

To post a comment you must log in.
Revision history for this message
Debbie Beliveau (debbie-beliveau) wrote :

Hi Evan,

Martin Pitt suggested I pass the userdel change to you and I figured I'd add the wget change as well.

Let me know if you have any questions or would rather me file a bug and attach a patch.

-Debbie

Revision history for this message
Matt Zimmerman (mdz) wrote :

perl-modules is declared as a Suggests of adduser. This means that perl-modules is "related" to the depending package and "can perhaps enhance its usefulness, but that installing this one without them is perfectly reasonable."

Since basic deluser functionality works without perl-modules, I think this is accurate. perl-modules is only required for --remove-home. I am surprised if ubiquity doesn't depend on perl somewhere in its dependency chain, but technically ubiquity should probably depend on perl if it requires this functionality.

Suggestions:
- Revise the comment and changelog with regard to the perl-modules dependency
- Consider using plain deluser (without --remove-home) instead of userdel, since they have different behavior (and could diverge more in the future)

343. By Debbie Beliveau

  * bin/oem-config-wrapper: use deluser instead of userdel to delete oem user
  * and change comment explaining why /home/oem is being deleted manually
  * debian/changelog: update existing 2.2.25 entry to reflect above changes
  * Change distribution to UNRELEASED

Revision history for this message
Debbie Beliveau (debbie-beliveau) wrote :

Modified changes in response to suggestions from Matt. Specifically, use deluser instead of userdel and update comments and changelog accordingly.

Unmerged revisions

343. By Debbie Beliveau

  * bin/oem-config-wrapper: use deluser instead of userdel to delete oem user
  * and change comment explaining why /home/oem is being deleted manually
  * debian/changelog: update existing 2.2.25 entry to reflect above changes
  * Change distribution to UNRELEASED

342. By Debbie Beliveau

* bin/oem-config-wrapper: Use userdel rather than deluser to remove oem user
  as deluser requires perl-modules which is a large, unspecified dependency
* debian/control: Add wget to Depends as ubi-language.py plugin calls wget

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: