Code review comment for lp://staging/~cyphermox/unity-control-center/rfkill-switch

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Right, that addresses https://bugs.launchpad.net/oem-priority/+bug/1318875; which has been a long discussed topic already. Will Cooke also knows all about it.

The issue is that the existence of multiple ways of toggling Flight Mode or otherwise disabling and enabling wifi is very confusing to users. To add to that, flight mode has been an issue in the gnome-control-center codebase in the past, and used to break in fun ways. I suspect it's no longer the case, but since it doesn't actually really do flight mode properly (toggles various things with rfkill, but that isn't necessarily saved across reboots), the least bad option seems to be to get rid of the toggle.

Users will still be able to disable networking from nm-applet.

As an alternative, we'd have to figure out how to correctly save rfkill states across reboots (perhaps using urfkill, which we've carefully iterated on to do just that on phones). It will remain that multiple rfkill UI points is confusing.

« Back to merge proposal