Unity Control Center

Merge lp://staging/~cyphermox/unity-control-center/rfkill-switch into lp://staging/unity-control-center

  1. rfkill-switch
  2. Merge into trunk
Proposed by Mathieu Trudel-Lapierre
Status: Needs review
Proposed branch: lp://staging/~cyphermox/unity-control-center/rfkill-switch
Merge into: lp://staging/unity-control-center
Diff against target: 169 lines (+0/-124)
1 file modified
panels/network/cc-network-panel.c (+0/-124)
To merge this branch: bzr merge lp://staging/~cyphermox/unity-control-center/rfkill-switch
Reviewer Review Type Date Requested Status
Iain Lane (community) Needs Information
Review via email: mp+283107@code.staging.launchpad.net

Commit message

Remove rfkill switch code.

Description of the change

Remove rfkill switch code.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

This kind of comes out of the blue.

Please provide an explanation, preferably in the form of a bug report.

review: Needs Information
Reply
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Right, that addresses https://bugs.launchpad.net/oem-priority/+bug/1318875; which has been a long discussed topic already. Will Cooke also knows all about it.

The issue is that the existence of multiple ways of toggling Flight Mode or otherwise disabling and enabling wifi is very confusing to users. To add to that, flight mode has been an issue in the gnome-control-center codebase in the past, and used to break in fun ways. I suspect it's no longer the case, but since it doesn't actually really do flight mode properly (toggles various things with rfkill, but that isn't necessarily saved across reboots), the least bad option seems to be to get rid of the toggle.

Users will still be able to disable networking from nm-applet.

As an alternative, we'd have to figure out how to correctly save rfkill states across reboots (perhaps using urfkill, which we've carefully iterated on to do just that on phones). It will remain that multiple rfkill UI points is confusing.

Reply

Unmerged revisions

12844. By Mathieu Trudel-Lapierre

Remove rfkill switch code, since the Airplane Mode switch confuses people.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches