Putting need fixing because the branch conflicts with trunk.
No matter that, I took a look to the code and tests, some notes:
- there are imported modules that are not used
- there is commented out (unused) code
- parentheses is superfluous in cases like the following:
if (query == ''):
- there's partially comented code like the following (all unused code should go away):
author = entry["title"]#.split(":")[0]
- lots and lots of FIXMEs
- missing tests for lots of code cases (if no news.entries, or if have content instead of summary, or the filtering of the query in the results, or when the summary is too large, or surfacing without department, etc)
Hello!
Putting need fixing because the branch conflicts with trunk.
No matter that, I took a look to the code and tests, some notes:
- there are imported modules that are not used
- there is commented out (unused) code
- parentheses is superfluous in cases like the following:
if (query == ''):
- there's partially comented code like the following (all unused code should go away):
author = entry[" title"] #.split( ":")[0]
- lots and lots of FIXMEs
- missing tests for lots of code cases (if no news.entries, or if have content instead of summary, or the filtering of the query in the results, or when the summary is too large, or surfacing without department, etc)