Merge lp://staging/~cwayne/ubuntu-rest-scopes/planet-ubuntu into lp://staging/ubuntu-rest-scopes
Proposed by
Chris Wayne
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~cwayne/ubuntu-rest-scopes/planet-ubuntu |
| Merge into: | lp://staging/ubuntu-rest-scopes |
| Diff against target: |
415 lines (+369/-1) 6 files modified
_static/icons/planetubuntu.svg (+27/-0) configs/scopes-info.yaml (+16/-1) src/scopes/ebay.py (+1/-0) src/scopes/tests/fixtures/planetubuntu.xml (+48/-0) src/scopes/tests/test_ubuntunews.py (+84/-0) src/scopes/ubuntunews.py (+193/-0) |
| To merge this branch: | bzr merge lp://staging/~cwayne/ubuntu-rest-scopes/planet-ubuntu |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Facundo Batista (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Planet ubuntu scope
To post a comment you must log in.
Unmerged revisions
- 164. By Chris Wayne
-
Make sure all preview widgets are tested, and also make fix tests for new cat
- 163. By Chris Wayne
-
Make Root department have all posts from all sources
- 162. By Chris Wayne
-
Fix test
- 161. By Chris Wayne
-
Fix typo that broke the everything
- 160. By Chris Wayne
-
Fix conflicts
- 159. By Chris Wayne
-
Address MP comments
- 158. By Chris Wayne
-
Ubuntu news scope, with departments!
- 157. By Chris Wayne
-
Add in departments
- 156. By Chris Wayne
-
Fixing scopes-info to not remove pageheader from other scopes
- 155. By Chris Wayne
-
Planet ubuntu scope + tests
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hello!
Putting need fixing because the branch conflicts with trunk.
No matter that, I took a look to the code and tests, some notes:
- there are imported modules that are not used
- there is commented out (unused) code
- parentheses is superfluous in cases like the following:
if (query == ''):
- there's partially comented code like the following (all unused code should go away):
author = entry["
- lots and lots of FIXMEs
- missing tests for lots of code cases (if no news.entries, or if have content instead of summary, or the filtering of the query in the results, or when the summary is too large, or surfacing without department, etc)