Code review comment for lp://staging/~coreygoldberg/window-mocker/py3

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi Corey,

There's still a few problems here. I grabbed your branch and built the package, but:

1) It only builds a python-windowmocker package, so there's no way to build & install the python3 variant.

2) If I run it from the source directly with:

PYTHONPATH=`pwd` python3 bin/window-mocker

then I get some python3 incompatibilities:

Traceback (most recent call last):
  File "bin/window-mocker", line 53, in <module>
    main()
  File "bin/window-mocker", line 25, in main
    application = create_application_from_data()
  File "/home/thomi/code/canonical/window-mocker/py3/windowmocker/__init__.py", line 83, in create_application_from_data
    if not isinstance(app_type_name, basestring):
NameError: global name 'basestring' is not defined

These two issues prevent me from testing this further. Please let me know once these have been fixed and I can look at it again.

review: Needs Fixing

« Back to merge proposal